MU07 - Chainlink Relayers #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
chapati23
commented
Aug 12, 2024
Co-authored-by: chapati <[email protected]>
* feat: mento gov utils scripts * fix: interfaces uses correct pragma * feat: pass and queue proposals * feat: remove --no-cache from script calls * fix: typo on a revert message * feat: improve logging * fix: remove tree that is pushed * fix: remove merge artifacts * feat: update readme
* chore: reproduce deployment broadcast files from on-chain data * Update bin/reproduce-mainnet-gov.ts Co-authored-by: Ryan Noble <[email protected]> * Apply suggestions from code review Co-authored-by: baroooo <[email protected]> * feat: regenerate json files after Baran's suggestions --------- Co-authored-by: Ryan Noble <[email protected]> Co-authored-by: baroooo <[email protected]>
|
I tried running the proposal on Baklava but it seams that the cLabs contracts team have also abandoned Baklava and SortedOracles is not up to date with the equivalent token implementation :( |
philbow61
reviewed
Aug 22, 2024
chapati23
commented
Aug 26, 2024
bowd
approved these changes
Aug 26, 2024
nvtaveras
reviewed
Aug 26, 2024
|
|
||
| function getProxyAdminOwner() internal view returns (address) { | ||
| if (ChainLib.isCelo()) { | ||
| return 0x655133d8E90F8190ed5c1F0f3710F602800C0150; // Mento Labs multisig |
There was a problem hiding this comment.
address looks correct, but maybe get it from contracts.dependency("MentoLabsMultisig") ?
|
Merging currently blocked until this is merged celo-org/governance#472 |
nvtaveras
approved these changes
Aug 28, 2024
philbow61
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MU07 Overview
relayed:CELOPHPandrelayed:PHPUSD.relayed:CELOPHPas the "equivalent token" for the PSO token address. Meaning that when paying with gas, the blockchain node will use therelayed:CELOPHPrate feed when gas is payed in the PSO token.Testing / development helpers
In order to have as close a structure as possible on testnets, this PR also deploys a few
MockChainlinkAggregatorcontracts:PHPUSDto AlfjoresPHPUSDto BaklavaCELOUSDto BaklavaUsing these on Alfajores we have:
relayed:CELOPHPbuilt from chainlink's own testnet aggregator ofCELOUSDand our mock aggregator ofPHPUSDrelayed:PHPUSDbuilt from our mock aggregator ofPHPUSDAnd on Baklava we have everything based only on our mock aggregators.
Scripts to interact with relayers:
RelayerStatus
Get a status output for all defined relayers:
RelayerReport
Trigger report on all relayers.
UpdateMockChainlinkAggregators
Update the mock aggregators on testnets with values from the mainnet aggregators that they mirror.
Other Changes
forge_scripthelper functions because it got out of hand and it was only used in a couple of placesverify:celoscancommand to check ABIs on celoscan first, and skip verification.Related Issues